Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken subpackages can't be whitelisted #118

Closed
pdemarino opened this issue Feb 19, 2020 · 2 comments · Fixed by #136
Closed

Broken subpackages can't be whitelisted #118

pdemarino opened this issue Feb 19, 2020 · 2 comments · Fixed by #136
Labels
type: feature request

Comments

@pdemarino
Copy link

I am trying to automate license verification for a package, and a transitive dependency is eyes@1.8.x, which has a broken package.json.

Can such a package be whitelisted?

Steps to replicate:

npm init
npm i winston@2.4.4
npx js-green-licenses --local .
@bcoe
Copy link
Contributor

bcoe commented Feb 19, 2020

👋 sounds like it would be us worth handling this edge-case, thanks for reporting.

@pdemarino
Copy link
Author

Thank you - this library has made my life so much easier!

@mat-sz mat-sz mentioned this issue May 18, 2020
Merged
JustinBeckwith pushed a commit that referenced this issue May 25, 2020
@mat-sz
feat: added skipping of package.json check if package is whitelisted (r…
0d95d18 
…esolves #118) (#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
2 participants
@bcoe @pdemarino