Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ API #71

Closed
davidzchen opened this issue Sep 16, 2015 · 1 comment
Closed

C++ API #71

davidzchen opened this issue Sep 16, 2015 · 1 comment
Assignees
@davidzchen
Labels
enhancement

Comments

@davidzchen
Copy link
Contributor

While Jsonnet is written in C++, the core API it exposes is a C API. It would be nice to have a proper C++ API as well.
@davidzchen davidzchen self-assigned this Sep 16, 2015
@davidzchen
Copy link
Contributor Author

I opened this because it would give me a better idea of what the Java API should look like (see #64).

A few ideas I had in mind for the C++ API are:

  • Simpler interface for returning output strings for _multi APIs, such as std::vector<std::string>.
  • Using std::function for the import callback
  • Using std::string instead of char*

Here is what I have so far: https://github.com/davidzchen/jsonnet/blob/cpp/cpp/jsonnet.h

Currently, this is just a wrapper around the libjsonnet C API. In the future, it might be nice to refactor some of the implementation details in libjsonnet.c for evaluating Jsonnet files/snippets and move them into the core C++ implementation.

@davidzchen davidzchen self-assigned this Oct 15, 2015
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Oct 20, 2015
@davidzchen
Add C++ API.
e74e200 
* Refactor common implementation details from libjsonnet.cpp into vm.
* Both C and C++ implementations are now thin wrappers on top of the
  low-level Vm API.
* Rearrange dependencies in BUILD file.

Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Oct 20, 2015
@davidzchen
Refactor common libjsonnet implementation details and C++ API.
2336e1f 
* Refactor common implementation details from libjsonnet.cpp into vm.
* Both C and C++ implementations are now thin wrappers on top of the
  low-level Vm API.
* Clean up library targets in BUILD file.
* Add simple tests for C++ wrappers.

Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Oct 20, 2015
@davidzchen
Add C++ API.
9ca2d3e 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Oct 20, 2015
@davidzchen
Add C++ API.
1b0d0aa 
Fixes google#71
@davidzchen davidzchen mentioned this issue Oct 20, 2015
Merged
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Oct 21, 2015
@davidzchen
Add C++ API.
5accd2b 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Oct 23, 2015
@davidzchen
Add C++ API.
df2cc93 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Nov 17, 2015
@davidzchen
Add C++ API.
f472fc9 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Feb 12, 2016
@davidzchen
Add C++ API.
a02de08 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 14, 2016
@davidzchen
Add C++ API.
7a93b9f 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 15, 2016
@davidzchen
Add C++ API.
1faf2ae 
Fixes google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 15, 2016
@davidzchen
Add preliminary C++ API.
c9e5f2b 
This change also adds an external dependency for gmock to the Bazel
build, which is used by the C++ library's unit test.

Issue google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 15, 2016
@davidzchen
Add preliminary C++ API.
425a5c6 
This change also adds an external dependency for gmock to the Bazel
build, which is used by the C++ library's unit test.

Issue google#71
davidzchen added a commit to davidzchen/jsonnet that referenced this issue Mar 15, 2016
@davidzchen
Add preliminary C++ API.
0ac9e69 
This change also adds an external dependency for gmock to the Bazel
build, which is used by the C++ library's unit test.

Issue google#71
This was referenced Nov 20, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidzchen davidzchen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sparkprime @davidzchen