Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loongarch64 support #1120

Closed
wants to merge 1 commit into from
Closed

add loongarch64 support #1120

wants to merge 1 commit into from

Conversation

212dandan
Copy link

Please review. If you have any questions, you can contact me at any time.

Copy link

google-cla bot commented Jan 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@johnbartholomew
Copy link
Collaborator

johnbartholomew commented Feb 10, 2024

Hi. It appears these are changes to Rapid YAML (the copy of the code in the third_party directory) not to jsonnet itself.

It would be better to contribute these changes upstream to the Rapid YAML project (edit: actually to c4core), and then they can be included in jsonnet when we update the Rapid YAML version. You could also check whether Rapid YAML version 0.5.0 already supports this architecture - if so, then I expect jsonnet will pick it up soon (with PR #1134)

@johnbartholomew johnbartholomew self-assigned this Feb 10, 2024
@johnbartholomew
Copy link
Collaborator

It seems someone has already opened a PR on the c4core project to add support for LoongArch: biojppm/c4core#119

@johnbartholomew
Copy link
Collaborator

Thanks for your contribution, however I'm going to close this as it is better to get this into Rapid YAML and not try to maintain a modified version of the Rapid YAML code within jsonnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants