Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Remove C++ install instructions from README #511

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Conversation

gdbelvin
Copy link
Contributor

Now that Certificate Transparency's Go no longer uses cgo
we can remove the apt-get install build-essential lines from
the readme.

Copy link
Collaborator

@cesarghali cesarghali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the change! Can you please add a statement instructing people to have openssl command installed and running?

@gdbelvin gdbelvin force-pushed the readme branch 2 times, most recently from 4625457 to dab320a Compare March 16, 2017 16:15
Copy link
Collaborator

@cesarghali cesarghali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

README.md Outdated
@@ -87,12 +86,13 @@ Set `$GOPATH` variable to point to your Go workspace directory and add `$GOPATH/

## Running a Key Transparency Cluster

1. Install [etcd v3.0.0](https://github.com/coreos/etcd/releases/tag/v3.0.0).
1. Install
- [Etcd v3.0.0](https://github.com/coreos/etcd/releases/tag/v3.0.0).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this does not rollback #512.

gdbelvin and others added 2 commits March 16, 2017 17:23
Now that Certificate Transparency's Go no longer uses cgo
we can remove the apt-get install build-essential lines from
the readme.
@gdbelvin gdbelvin merged commit 4dbe8fe into google:master Mar 17, 2017
@gdbelvin gdbelvin deleted the readme branch April 7, 2017 17:44
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants