Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/kf/commands: group command names #130

Merged
merged 1 commit into from
Jun 4, 2019
Merged

pkg/kf/commands: group command names #130

merged 1 commit into from
Jun 4, 2019

Conversation

poy
Copy link
Contributor

@poy poy commented Jun 4, 2019

This CL uses k8s.io/kubernetes/pkg/kubectl/util/templates to group the
commands into logical groups.

fixes #55

@poy poy added enhancement New feature or request docs Updates to the docs labels Jun 4, 2019
@poy poy self-assigned this Jun 4, 2019
@googlebot googlebot added the cla: yes PR submitter has signed the CLA label Jun 4, 2019
josephlewis42
josephlewis42 approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@josephlewis42 josephlewis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming these new dependencies can't be tidy'd

@poy
Copy link
Contributor Author

poy commented Jun 4, 2019 •
edited
Loading

@josephlewis42 I ran go mod tidy and re-pushed.

@poy
pkg/kf/commands: group command names
84b35b9 
This CL uses k8s.io/kubernetes/pkg/kubectl/util/templates to group the
commands into logical groups.

fixes #55
@poy poy merged commit e7bc6e1 into master Jun 4, 2019
@poy poy deleted the feature/55 branch June 20, 2019 03:35
@itskingori itskingori mentioned this pull request Jul 1, 2019
Closed
@ajm188 ajm188 mentioned this pull request Mar 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlewis42 josephlewis42 josephlewis42 approved these changes

@mattysweeps mattysweeps Awaiting requested review from mattysweeps

@juliaguo juliaguo Awaiting requested review from juliaguo

Assignees

@poy poy

Labels
cla: yes PR submitter has signed the CLA docs Updates to the docs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Logically group commands
3 participants
@poy @josephlewis42 @googlebot