Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

[WIP] Make metrics E2E test work in PROW #318

Closed
wants to merge 24 commits into from

Conversation

nachocano
Copy link
Member

Fixes #317

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nachocano
To complete the pull request process, please assign harwayne
You can assign the PR to them by writing /assign @harwayne in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachocano
Copy link
Member Author

let's see if this fixes it

@nachocano
Copy link
Member Author

trying one more time with @chizhg suggestion in #317

@nachocano nachocano changed the title Make metrics E2E test work in PROW [WIP] Make metrics E2E test work in PROW Oct 4, 2019
@chizhg
Copy link
Member

chizhg commented Oct 4, 2019

/test pull-google-knative-gcp-integration-tests

test/e2e-common.sh Outdated Show resolved Hide resolved
@knative-prow-robot
Copy link
Contributor

@nachocano: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-google-knative-gcp-integration-tests 6049627 link /test pull-google-knative-gcp-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nachocano
Copy link
Member Author

@chaodaiG @chizhg I made the change but still no luck.. is weird... If you guys have access to the UI, we can check the metrics explorer under monitoring to see if they are actually sent.
I can add a big sleep so that we can login in the cluster, and see the logs from the pods as well...
will ping you back next week, thanks!

@nachocano nachocano closed this Oct 15, 2019
@nachocano
Copy link
Member Author

will continue on another one

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StackDriver metrics e2e test does not work in PROW
4 participants