Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"leveldbutil dump" on manifest produces truncated output if keys contain NUL #162

Closed
cmumford opened this issue Sep 9, 2014 · 1 comment
Assignees

Comments

@cmumford
Copy link
Contributor

cmumford commented Sep 9, 2014

Original issue 156 created by ben.darnell on 2013-03-29T17:48:20.000Z:

What steps will reproduce the problem?

  1. Create a database with keys that contain embedded NUL bytes
  2. Run "leveldbutil dump" on its manifest

What is the expected output? What do you see instead?

If one of the largest or smallest keys for an sstable contains an embedded NUL byte, the output for that VersionEdit will be truncated at that point. NULs (and other special characters) should be escaped.

What version of the product are you using? On what operating system?

LevelDB 1.9 on OS X 10.8.

Please provide any additional information below.

leveldbutil also needs to be added to .gitignore, and perhaps to the "make all" target.

@cmumford
Copy link
Contributor Author

cmumford commented Sep 9, 2014

Comment #1 originally posted by dgrogan@chromium.org on 2013-05-15T00:11:11.000Z:

<empty>

@cmumford cmumford self-assigned this Sep 9, 2014
@cmumford cmumford closed this as completed Sep 9, 2014
maochongxin pushed a commit to maochongxin/leveldb that referenced this issue Jul 21, 2022
Fixes google#159: Add inclusion of cstdio to files using stdout, printf and etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant