define PLATFORM_IS_LITTLE_ENDIAN on BSD's correctly #249
Assignees
Comments
cmumford
added a commit
that referenced
this issue
Sep 16, 2014
Changes are: * Update version number to 1.18 * Replace the basic fprintf call with a call to fwrite in order to work around the apparent compiler optimization/rewrite failure that we are seeing with the new toolchain/iOS SDKs provided with Xcode6 and iOS8. * Fix ALL the header guards. * Createed a README.md with the LevelDB project description. * A new CONTRIBUTING file. * Don't implicitly convert uint64_t to size_t or int. Either preserve it as uint64_t, or explicitly cast. This fixes MSVC warnings about possible value truncation when compiling this code in Chromium. * Added a DumpFile() library function that encapsulates the guts of the "leveldbutil dump" command. This will allow clients to dump data to their log files instead of stdout. It will also allow clients to supply their own environment. * leveldb: Remove unused function 'ConsumeChar'. * leveldbutil: Remove unused member variables from WriteBatchItemPrinter. * OpenBSD, NetBSD and DragonflyBSD have _LITTLE_ENDIAN, so define PLATFORM_IS_LITTLE_ENDIAN like on FreeBSD. This fixes: * issue #143 * issue #198 * issue #249 * Switch from <cstdatomic> to <atomic>. The former never made it into the standard and doesn't exist in modern gcc versions at all. The later contains everything that leveldb was using from the former. This problem was noticed when porting to Portable Native Client where no memory barrier is defined. The fact that <cstdatomic> is missing normally goes unnoticed since memory barriers are defined for most architectures. * Make Hash() treat its input as unsigned. Before this change LevelDB files from platforms with different signedness of char were not compatible. This change fixes: issue #243 * Verify checksums of index/meta/filter blocks when paranoid_checks set. * Invoke all tools for iOS with xcrun. (This was causing problems with the new XCode 5.1.1 image on pulse.) * include <sys/stat.h> only once, and fix the following linter warning: "Found C system header after C++ system header" * When encountering a corrupted table file, return Status::Corruption instead of Status::InvalidArgument. * Support cygwin as build platform, patch is from https://code.google.com/p/leveldb/issues/detail?id=188 * Fix typo, merge patch from https://code.google.com/p/leveldb/issues/detail?id=159 * Fix typos and comments, and address the following two issues: * issue #166 * issue #241 * Add missing db synchronize after "fillseq" in the benchmark. * Removed unused variable in SeekRandom: value (issue #201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original issue 243 created by fabian.raetz on 2014-06-30T14:00:05.000Z:
define PLATFORM_IS_LITTLE_ENDIAN on BSD's correctly
What steps will reproduce the problem?
What is the expected output?
A successfull build.
What do you see instead?
/port/port_posix.h:67:35: error: '__BYTE_ORDER' was not declared in this scope
./port/port_posix.h:67:35: error: '__LITTLE_ENDIAN' was not declared in this scope
What version of the product are you using? On what operating system?
OpenBSD -current
Please provide any additional information below.
This will also fixes:
Issue 137 (NetBSD) https://code.google.com/p/leveldb/issues/detail?id=137
Issue 192 (DragonflyBSD) https://code.google.com/p/leveldb/issues/detail?id=192
Thanks in advance,
Fabian Raetz
The text was updated successfully, but these errors were encountered: