Use a singleton for ShortNumberInfo in PhoneExtractor::RunFocusedArena #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
katbohm
reviewed
Nov 16, 2023
| ShortNumberInfoTest() : short_info_() { | ||
| PhoneNumberUtil::GetInstance()->SetLogger(new StdoutLogger()); | ||
| ShortNumberInfoTest() : short_info_(ShortNumberInfo::GetInstance()) { | ||
| PhoneNumberUtil::GetInstance()->SetLogger(new StdoutLogger()); |
There was a problem hiding this comment.
I think the space should stay.
| @@ -44,9 +44,6 @@ class PhoneNumberUtil; | |||
|
|
|||
| class ShortNumberInfo { | |||
| public: | |||
| ShortNumberInfo(); | |||
| ~ShortNumberInfo(); | |||
There was a problem hiding this comment.
By removing these public constructor & destructor, the public API is changing. I don't think we can do that since the library is widely used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is expected to reduce CPU usage by only initializing ShortNumberInfo once throughout the lifetime of the application. This pattern is already used in PhoneNumberUtil.