-
Notifications
You must be signed in to change notification settings - Fork 236
C binding for lmctfy #13
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,297 @@ | |||
#ifndef LMCTFY_C_BINDING_LMCTFY_C_H_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the includes into "/includes"? I think the c bindings implementation is still okay to have where it is.
I noticed that the parameter order does not follow the coding style (Should be input first then output). I will change them later. |
Please take another look. Besides those lines mentioned in the reviews, I made the following changes as well:
|
I just made a rebase onto 0.4.5. Please take another look. |
Thanks. Ignore the travis error - its not fully setup. There's a jenkins build and test that should be firing up. |
Can one of the admins verify this patch? |
ok to test |
All tests passing. |
C binding for lmctfy.
lmctfy_
_raw
. The_raw
functions takes a serialized buffer to represent the protobuf generated object.::util::Status
or::util::StatusOr
has a corresponding function in the c library which takes astruct status *
as its first parameter. The status structure will be used as output. Those functions will also check the error code in the status structure before executing other code in the functions. If the error code is not zero, they will return immediately with the error code.