fix(tabs): Allow tab hrefs to point anywhere

* Check for '#' before proceeding with querySelector and tab state modification * Allows anchors to point to other links Closes #4072
google · Oct 19, 2016 · 14b6cb1 · 14b6cb1
1 parent feca3a8
commit 14b6cb1
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/tabs/tabs.js b/src/tabs/tabs.js
@@ -140,13 +140,15 @@
       }
 
       tab.addEventListener('click', function(e) {
-        e.preventDefault();
-        var href = tab.href.split('#')[1];
-        var panel = ctx.element_.querySelector('#' + href);
-        ctx.resetTabState_();
-        ctx.resetPanelState_();
-        tab.classList.add(ctx.CssClasses_.ACTIVE_CLASS);
-        panel.classList.add(ctx.CssClasses_.ACTIVE_CLASS);
+        if (tab.getAttribute('href').charAt(0) === '#') {
+          e.preventDefault();
+          var href = tab.href.split('#')[1];
+          var panel = ctx.element_.querySelector('#' + href);
+          ctx.resetTabState_();
+          ctx.resetPanelState_();
+          tab.classList.add(ctx.CssClasses_.ACTIVE_CLASS);
+          panel.classList.add(ctx.CssClasses_.ACTIVE_CLASS);
+        }
       });
 
     }