Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.3] Search textfield in header broken. #1423

Closed
Zodiase opened this issue Aug 18, 2015 · 9 comments
Closed

[1.0.3] Search textfield in header broken. #1423

Zodiase opened this issue Aug 18, 2015 · 9 comments
Labels

Comments

@Zodiase
Copy link
Contributor

Zodiase commented Aug 18, 2015

Compare this codepen using 1.0.3
and this codepen using 1.0.2

Comparison

@tleunen
Copy link
Contributor

tleunen commented Aug 18, 2015

All the textfields are broken, not just the expandable one...
http://www.getmdl.io/components/index.html#textfields-section

@Zodiase
Copy link
Contributor Author

Zodiase commented Aug 18, 2015

For the textfield in header, simply adding background: 16px; made it work. This line was in 1.0.2 but removed in 1.0.3.

@Zodiase
Copy link
Contributor Author

Zodiase commented Aug 18, 2015

That line was removed in d1be039. Why?

@tleunen
Copy link
Contributor

tleunen commented Aug 18, 2015

background: none makes more sense than just using an arbitrary value. That's probably why it was removed.

@Zodiase
Copy link
Contributor Author

Zodiase commented Aug 18, 2015

@tleunen
Except background: none is missing. Now I wonder why that arbitrary value was used in the first place. :S

@Zodiase
Copy link
Contributor Author

Zodiase commented Aug 18, 2015

Probably should @sgomes.

@addyosmani addyosmani added the P0 label Aug 18, 2015
Zodiase pushed a commit to Zodiase/material-design-lite that referenced this issue Aug 18, 2015
@sgomes
Copy link
Contributor

sgomes commented Aug 18, 2015

@tleunen is right, that's exactly why it was removed, but it had the unintended behaviour this bug describes. Thanks for reporting this, @Zodiase!

@addyosmani
Copy link
Contributor

Thanks for catching this so quickly folks and sorry about the regression. Let's land a fix for this in a 1.0.4 and get it out the door asap so it doesn't cause further breakage.

@sgomes
Copy link
Contributor

sgomes commented Aug 18, 2015

PRs out for both master and mdl-1.0 branches.

addyosmani added a commit that referenced this issue Aug 19, 2015
Fix textfield background regression. Fixes #1423
@sgomes sgomes closed this as completed in b91c2e4 Aug 19, 2015
addyosmani added a commit that referenced this issue Aug 19, 2015
Fix textfield background regression. Fixes #1423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants