Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall menu bottom row disappears when resizing #4058

Closed
listedegarde opened this issue Feb 1, 2016 · 6 comments
Closed

Waterfall menu bottom row disappears when resizing #4058

listedegarde opened this issue Feb 1, 2016 · 6 comments
Assignees
Labels

Comments

@listedegarde
Copy link

Problem:
When shrinking and then growing the window, the waterfall's bottom menu does not reappear if the user has scrolled between times.

Expected result:
When growing the window, the bottom row should always reappear once scrolled back to the top.

Steps to reproduce:

  1. Visit http://getmdl.io/components/index.html#layout-section
  2. Scroll down to "Waterfall header" sample
  3. Shrink the window to < 1024px, but > 850px and scroll to the bottom of the Waterfall sample.
  4. Grow the window to > 1024px again, and scroll to the top of the Waterfall sample: no bottom row with menu items will be visible.

Note: the issue doesn't seem to act quite the same way if you shrink below 850px. When you do, the bottom bar can usually be restored in > 1024px by scrolling down to the bottom and back to the top.

Tested on:
Firefox 44 on Ubuntu 14.04
Chrome 48 on Ubuntu 14.04

@listedegarde
Copy link
Author

Another interesting point I just discovered: if you double-click on the header's main "title" bar (with the title and search), the bottom row will with the menu items will magically reappear!

@sgomes
Copy link
Contributor

sgomes commented Feb 2, 2016

Nice catch, @listedegarde! I'll look into this.

@sgomes sgomes self-assigned this Feb 2, 2016
@sgomes
Copy link
Contributor

sgomes commented Feb 2, 2016

Found while debugging: clicking the header seems to reset the incorrect behaviour, for some reason.

@sgomes
Copy link
Contributor

sgomes commented Feb 2, 2016

Found the issue. PR at #4064.

@listedegarde
Copy link
Author

Awesome! Thank you.

Garbee added a commit that referenced this issue Feb 2, 2016
Fix issues with waterfall headers on small screens. Fixes #4058.
@sgomes
Copy link
Contributor

sgomes commented Feb 2, 2016

No worries, thank you for the clear bug description, @listedegarde! This has been merged into the mdl-1.1 branch and will be included in v1.1.1 when released.

@sgomes sgomes closed this as completed Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants