Ability to use an existing drawer button if it already exists #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, just needs a squash. |
|
LGTM2 after squash :) |
Making it possible to use an existing menu button if it exists in the DOM already Undoing the gitignore change - it's not relevant to this PR Updating gitignore Making it possible to use an existing menu button if it exists in the DOM already Undoing the gitignore change - it's not relevant to this PR
|
LGTM3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment layout.js injects a hamburger menu button.
On Web fundamentals I'm hoping to avoid having to grab an icon font and just inline the SVG images needed, however this isn't possible with the current version of MDL.
This PR is a small tweak to check if a menu buttons already exists, otherwise create and inject an element.