fix tab navigation for external links #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is duplicate of lines 552 to 557 without allowing external links.
|
@sgomes i do what you ask to me but I got 'continuous-integration/drone — the build failed', is my PR good ? |
|
@sad: Looks like our CI was acting up. I've restarted the build, let's see how it goes. |
|
Looks good now, thanks! Merging. |
sgomes
added a commit
that referenced
this pull request
Mar 16, 2016
fix tab navigation for external links
|
This didn't fix the issue for me. I'm hitting this same reference issue in Should I be using tabs in a different way to benefit from this fix?? What I'm doingI'm trying to use MDL tabs with Here's a codepen replicating the issue on the latest release ( While the example doesn't include ui-router, it has the same symptoms that I'm seeing with ui-router.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4177 opening again in
mdl-1.1branchThis code is duplicate of lines 552 to 557 without allowing external links.