Use the Event constructor in browsers that support it. Fixes #4188. #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For old IE, it falls back to createEvent + initEvent, the latter of which is deprecated and may be missing from some browsers.
|
Downgrade is also needed. |
|
Good catch, thanks! Will amend. |
|
Sorted, downgrade is now fixed too. As an aside, Drone is acting up, so the build may fail. @crhym3 is on it. |
|
LGTM, our only other uses of initEvent are internal to tests. So they don't need to be upgraded right away. |
|
Thanks, @Garbee! |
sgomes
added a commit
that referenced
this pull request
Mar 10, 2016
Use the Event constructor in browsers that support it. Fixes #4188.
| @@ -351,9 +358,15 @@ componentHandler = (function() { | |||
| upgrades.splice(componentPlace, 1); | |||
| component.element_.setAttribute('data-upgraded', upgrades.join(',')); | |||
|
|
|||
| var ev = document.createEvent('Events'); | |||
| ev.initEvent('mdl-componentdowngraded', true, true); | |||
| component.element_.dispatchEvent(ev); | |||
There was a problem hiding this comment.
Looks like you removed the dispatchEvent...
There was a problem hiding this comment.
You're right, I did remove it on the downgrade event! Thanks for the keen eye, @tleunen!
sgomes
pushed a commit
that referenced
this pull request
Mar 21, 2016
andreasonny83
added a commit
to andreasonny83/material-design-lite
that referenced
this pull request
May 13, 2016
* master: fixing mocha errors fixing eslint related errors and warnings eslint error fixes Remove automatic name/value example. Functionality was removed before publishing. Update button note to reflect disabled classes purpose. Fix downgrade event firing (bug introduced in google#4191) Small tweak to make Closure compiler happy Bump to 1.1.3 Fix grammatical error Fix snackbar position on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For old IE, it falls back to createEvent + initEvent, the latter of
which is deprecated and may be missing from some browsers.
@surma @Garbee PTAL!