Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserializing dict for stateclass #520

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix deserializing dict for stateclass #520

merged 2 commits into from
Jun 25, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Jun 24, 2024 •
edited
Loading

Fixes #518, #330

richard-to
richard-to approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mesop/examples/dict_state.py Show resolved Hide resolved
mesop/dataclass_utils/dataclass_utils.py Show resolved Hide resolved
mesop/dataclass_utils/dataclass_utils.py Show resolved Hide resolved
@wwwillchen
Copy link
Collaborator Author

Thanks for the review.

@wwwillchen wwwillchen merged commit 63a2e39 into google:main Jun 25, 2024
3 checks passed
@wwwillchen wwwillchen deleted the i518 branch June 25, 2024 06:15
@dltn dltn mentioned this pull request Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dict state not persisting correctly
2 participants
@wwwillchen @richard-to