-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sandboxed mode to HTML component #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
commented
Jun 26, 2024
wwwillchen
commented
Jun 26, 2024
richard-to
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I like the api here. I think better than the alternative of having the embed element accept html.
Need to hold off, there's a security issue with this approach. |
Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach: This iframes HTML content (potentially from end-user input) in a sandboxed iframe without "allow-same-origin" to ensure the content does not run on the same origin as the main Mesop app.
This uses a double-iframing approach because we cannot directly use
<iframe srcdoc="${html}">
from the main Mesop app because Mesop by default applies a stringent CSP (e.g. trusted types) and iframe documents using srcdoc automatically inherit their parent's CSP and this makes the iframe basically unusable for many use cases.Instead we iframe
sandboxed_iframe.html
which is served with a minimal CSP that only prevents being iframed by other origins besides the Mesop app and then withinsandboxed_iframe.html
we render the (untrusted) HTML content inside a sandboxed iframe.Fixes #156.