Add file backend for state sessions #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also adds a new dependency with msgpack. For now we use it to serialize/deserialize the JSON strings of the Mesop state. In the future we will want to serialize everything with msgpack. The reason we can't do this now is because we will need to add msgpack encoding/decoding rules to support non-standard data types. This change also adds a new config variable called MESOP_STATE_SESSION_BACKEND_FILE_BASE_DIR which allows the user to specify the location where the state sessions get written.
wwwillchen
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Another exciting change!
I think we could use this w/ Cloud Run+GCS using https://cloud.google.com/run/docs/configuring/services/cloud-storage-volume-mounts
This could become a very nice option that's: a) scalable (you will basically not run out of GCS space), b) cheap and c) fast - according to https://github.com/GoogleCloudPlatform/gcsfuse/blob/master/docs/benchmarks.md#results
Ah nice! That's a great find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also adds a new dependency with msgpack. For now we use it to serialize/deserialize the JSON strings of the Mesop state. In the future we will want to serialize everything with msgpack.
The reason we can't do this now is because we will need to add msgpack encoding/decoding rules to support non-standard data types.
This change also adds a new config variable called MESOP_STATE_SESSION_BACKEND_FILE_BASE_DIR which allows the user to specify the location where the state sessions get written.
Ref #556