Add example patterns for modal and toast #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
approved these changes
Jul 4, 2024
demo/modal.py
Outdated
| style=me.Style( | ||
| align_items="center", | ||
| display="grid", | ||
| height="100vh", |
There was a problem hiding this comment.
I'm a little surprised this is 100vh and the parent box is 100%, I would have expected the opposite
This was referenced Jul 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes two example components for modals and toasts. These are two common UI widgets that Mesop does not currently have.
Unfortunately the Angular Components for Dialog and Snackbar is not easy to add to Mesop. This is because these two components takes in a Component or Template. So it does not seem possible to use projection into ng-content (like we do with badge or button).
The good news is that those two components aren't that complicated and it is relatively easy to create similar implementations using pure Mesop.
Ref: #338
Ref: #320
Ref: #278
Example modal
Example toast