Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo gallery: chat_inputs & visual polish #600

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

wwwillchen
Copy link
Collaborator

No description provided.

@wwwillchen wwwillchen changed the title Update demo gallery: chat_inputs Update demo gallery: chat_inputs & visual polish Jul 11, 2024
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. These look pretty good. Much better than the default chat input. Tempted to use one of these in chat.py. But probably better to keep it as the default for simplicity.

Maybe one suggestion I have it to wrap the examples in a @me.component to show how these could be reusable. But I think that will be more useful once you add the copy code stuff in #579 and #580, so I think fine for now.

@wwwillchen
Copy link
Collaborator Author

Nice. These look pretty good. Much better than the default chat input. Tempted to use one of these in chat.py. But probably better to keep it as the default for simplicity.

Maybe one suggestion I have it to wrap the examples in a @me.component to show how these could be reusable. But I think that will be more useful once you add the copy code stuff in #579 and #580, so I think fine for now.

good idea - done.

@wwwillchen wwwillchen merged commit 935edf9 into google:main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants