Fix bug with .env not loading for pip installs #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the default `load_dotenv()` behavior is not working as expected for pip installs. To fix this, we update the code to explicitly search the user's current working directory. This does not work when running in Bazel, so we still need to use `load_dotenv()`. Tested this by running ./scripts/pip.sh and also testing ./scripts/cli.sh.
wwwillchen
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the default
load_dotenv()behavior is not working as expected for pip installs. To fix this, we update the code to explicitly search the user's current working directory.This does not work when running in Bazel, so we still need to use
load_dotenv().Tested this by running ./scripts/pip.sh and also testing ./scripts/cli.sh.
Ref: #592