Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Budget more time for playwright tests & disable retries #607

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Budget more time for playwright tests & disable retries #607

merged 3 commits into from
Jul 14, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Jul 12, 2024 •
edited
Loading

  • Removed retries for the overall test suites because it can mask real issues and we can mark specific tests as flaky, such as web component slot test which is flaky both locally and on GitHub.

@wwwillchen wwwillchen marked this pull request as draft July 12, 2024 07:33
@wwwillchen wwwillchen marked this pull request as ready for review July 12, 2024 23:10
@wwwillchen wwwillchen changed the title Budget more time for playwright tests Budget more time for playwright tests & disable retries Jul 14, 2024
@wwwillchen wwwillchen merged commit 0e0cb95 into google:main Jul 14, 2024
3 checks passed
@wwwillchen wwwillchen deleted the budget_playwright branch July 14, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwillchen @richard-to