Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DuoChat codelab #620

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Create DuoChat codelab #620

merged 4 commits into from
Jul 17, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Jul 13, 2024 •
edited
Loading

@wwwillchen wwwillchen changed the title Create codelab Create DuoChat codelab Jul 17, 2024
@wwwillchen wwwillchen marked this pull request as ready for review July 17, 2024 06:48
richard-to
richard-to approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's a nice codelab. Each section is consistent in its tone and structure. I think it's good that it doesn't go too in-depth into the technical details.

I think is definitely a really good addition to the documentation.

docs/codelab/index.md Outdated Show resolved Hide resolved
docs/codelab/5.md
Now that we have a dedicated conversation page with a multi-column layout, let's make some final improvements to enhance the user experience:

1. Navigate to the conversations page at the start of a conversation.
2. Implement auto-scrolling to keep the latest messages in view.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this behavior in the hugging face demo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - the hf demo was using out of date code. I've updated and repushed it.

docs/codelab/5.md Show resolved Hide resolved
@wwwillchen wwwillchen merged commit 3c18980 into google:main Jul 17, 2024
3 checks passed
@wwwillchen wwwillchen deleted the gemini_guide branch July 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-to richard-to richard-to approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwillchen @richard-to