Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow data URL for font-src #646

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

richard-to
Copy link
Collaborator

In the Code Mirror webcomponent, I noticed that Code Mirror uses data URLs for some fonts. This was causing some CSP errors related to fonts.

So adding data: to font-src section.

In the Code Mirror webcomponent, I noticed that Code Mirror uses data
URLs for some fonts. This was causing some CSP errors related to fonts.

So adding `data:` to font-src section.
Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-src isn't very security sensitive so LGTM.

@richard-to richard-to merged commit 011c5a7 into google:main Jul 19, 2024
3 checks passed
@richard-to richard-to deleted the add-data-font-src branch July 24, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants