Add example headers to patterns demos. #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common use case to have a header for the app. This example was extracted from the prompt tuner console app that I've been working on.
wwwillchen
reviewed
Jul 22, 2024
| with header(max_width=None): | ||
| with header_section(): | ||
| me.text( | ||
| "Mesop", type="headline-6", style=me.Style(margin=me.Margin(bottom=0)) |
There was a problem hiding this comment.
side-note: I've wondered whether we should just reset the default margins for headings to 0. I find it quite annoying to set it to margin 0, and it would improve cross-browser consistency.
There was a problem hiding this comment.
Yeah that's an interesting idea. On one hand, I definitely agree that the default headline margins are kind of absurdly large.
I think having some sensible margin bottom is kind of good, so it doesn't always need to be tweaked. Since 0 probably wouldn't be great in all cases.
wwwillchen
approved these changes
Jul 22, 2024
| me.slot() | ||
|
|
||
|
|
||
| def merge_styles( |
There was a problem hiding this comment.
this is interesting :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common use case to have a header for the app. This example was extracted from the prompt tuner console app that I've been working on.
Also think it will be useful for the Mesop AI stuff.
Ref: #338
Full width
Mobile