Support non-generating coroutines as event handlers. #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
requested changes
Aug 16, 2024
malmaud
force-pushed
the
coroutine_handler
branch
2 times, most recently
from
7ab01b2
to
1f259bd
Compare
|
Not sure if I can retrigger the CI on my side, but the tests pass locally for me now. |
I ran the ci and there's a test failing. Take a look at the error message |
|
It looks like that CI run is from before I fixed the error on my branch via a force-push, and then didn't automatically re-run. |
wwwillchen
reviewed
Aug 19, 2024
malmaud
force-pushed
the
coroutine_handler
branch
from
1f259bd
to
a5a3e80
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to elide a solitary final 'yield' from async event handlers that don't stream responses, which seems more ergonomic.