[UI change] Remove label for uploader button. #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Slight breaking UI change since the "No file chosen" and filename labels have been removed. They were kind of redundant - The user can add the labels themselves if necessary. This gives more flexibility - Also resolves the issue of the filename not being reset.
wwwillchen
changed the title
wwwillchen
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight breaking UI change since the "No file chosen" and filename labels have been removed. They were kind of redundant
The user can add the labels themselves if necessary. This gives more flexibility
Also resolves the issue of the filename not being reset.
Closes Add title to uploader -> Allow user to change the text of the uploader button when nothing is chosen #764 (User mainly wanted to change the label to remove it)
Closes Reset uploader component #739 (User wanted to reset the file chosen label after a file was selected)