Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MESOP_CONCURRENT_UPDATES_ENABLED env var #868

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

wwwillchen
Copy link
Collaborator

@wwwillchen wwwillchen commented Aug 28, 2024

This also fixes the issue where our playwright artifacts weren't being properly saved/uploaded on GitHub Actions.

Addresses #623.

@wwwillchen wwwillchen changed the title Prototype: allow concurrent updates (configurable by env var) Support MESOP_CONCURRENT_UPDATES_ENABLED env var Sep 18, 2024
@wwwillchen wwwillchen marked this pull request as ready for review September 18, 2024 06:08
Copy link
Collaborator

@richard-to richard-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Not able to test this out yet, so looking forward to seeing how far this can be pushed.

I think changes look good. I would have liked to see some more test cases, but since it is behind a flag I think it's OK and we can probably gather feedback from users on edge cases.

@wwwillchen
Copy link
Collaborator Author

Nice. Not able to test this out yet, so looking forward to seeing how far this can be pushed.

I think changes look good. I would have liked to see some more test cases, but since it is behind a flag I think it's OK and we can probably gather feedback from users on edge cases.

+1. I'm sure there's some funky stuff with this, for example, the 1 second is fairly arbitrary which could be too long or too short depending on the use case, but this should address the core use case in #623

@wwwillchen wwwillchen merged commit a39bc6d into google:main Sep 18, 2024
6 checks passed
@wwwillchen wwwillchen deleted the concurrent-state branch September 18, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants