Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some usages of scroll-to #915

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

richard-to
Copy link
Collaborator

We can remove the intentional delay on scroll-to now.

There is one case where this does not work as expected though. When the chat message is not streamed, the scroll to with hidden box strategy does not work since the output is too fast. This occurred on LLM Rewriter example. But I updated it to fake the streaming.

Also decreases the size of the hidden box, so it is less jarring when the box disappears.

We can remove the intentional delay on scroll-to now.

There is one case where this does not work as expected though. When the
chat message is not streamed, the scroll to with hidden box strategy
does not work since the output is too fast. This occurred on LLM
Rewriter example. But I updated it to fake the streaming.
Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LLM rewriter case is interesting, but seems pretty unusual (e.g. doing short-running work across multiple yields). We could separate each yield into a separate JS task so that scroll into view could take effect, but this seems pretty rare so we can hold off on that. Thanks for fixing these!

@richard-to richard-to merged commit 41692f5 into google:main Sep 1, 2024
5 checks passed
@richard-to richard-to deleted the scroll-to-update branch September 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants