Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure exposure, maps to tone mapping exposure #389

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Configure exposure, maps to tone mapping exposure #389

merged 2 commits into from
Feb 28, 2019

Conversation

cdata
Copy link
Contributor

@cdata cdata commented Feb 27, 2019 •
edited
Loading

exposure

This change proposes the addition of a property exposure for controlling toneMappingExposure on the renderer.

  • This default toneMappingExposure has been changed to 1.0
  • Fidelity tests that check against Filament have had their exposures manually configured down to 0.9 to match the old default
  • In the image above, exposure is oscillating between 0.0 and 4.0.

Fixes #209

@cdata cdata changed the base branch from shadow-strength to master February 27, 2019 21:43
mrdoob
mrdoob previously approved these changes Feb 27, 2019
View reviewed changes
@cdata cdata merged commit 26708e9 into master Feb 28, 2019
@cdata cdata deleted the configurable-exposure branch February 28, 2019 00:09
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsantell jsantell jsantell approved these changes

@mrdoob mrdoob mrdoob left review comments

@smalls smalls Awaiting requested review from smalls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdata @mrdoob @jsantell