Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cloud improvements #4228

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Point cloud improvements #4228

merged 3 commits into from
Apr 19, 2023

Conversation

elalish
Copy link
Collaborator

@elalish elalish commented Apr 18, 2023

Fixes #4217

We had a bunch of code that was mesh-specific, when really it should apply equally well to point or line objects.

This also updates our editor to automatically create surface hotspots only for animated models and world-position hotspots otherwise, which allows this to work for point cloud models.

@elalish elalish self-assigned this Apr 18, 2023
@elalish elalish merged commit 8205097 into master Apr 19, 2023
@elalish elalish deleted the pointCloud branch April 19, 2023 01:02
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* editor: use surface hotspots only for animated models

* remove mesh-specific checks

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant