Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustify pointing #4238

Merged
merged 2 commits into from
Apr 21, 2023
Merged

robustify pointing #4238

merged 2 commits into from
Apr 21, 2023

Conversation

elalish
Copy link
Collaborator

@elalish elalish commented Apr 21, 2023

Once in a while I see our pointer get "stuck down", as in mouse moves with no button down continue to rotate the model. It's rare and usually only happens when dev tools is open. However, recently we found one older macbook that repros it semi-consistently on a particular page, so figured it's better safe than sorry. This should be a solid backstop to any weird situation where we fail to get a pointerup or pointercancel event.

@elalish elalish self-assigned this Apr 21, 2023
@elalish elalish requested a review from diegoteran April 21, 2023 22:09
@elalish elalish merged commit 6c8216b into master Apr 21, 2023
@elalish elalish deleted the robustPointing branch April 21, 2023 22:25
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* robustify pointing

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants