Editor open graph metadata #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
requested changes
Oct 25, 2023
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* Add href to AR button, improve accessibility * Add Open Graph title and description for editor * Broaden copy scope to include 3D, not just AR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3151. By adding a og:title and og:description, the URL unfurl looks slicker! As a note, Discord seems to filter out < and > characters and the < and > characters screw with linting. The solution I found was to use Small Less-Than Sign and Small Greater-Than Sign unicode characters which convey the same meaning but don't screw with other systems.
Confirmed the changes worked and all tests passed. See the following examples from discord:
Before:
After:
Please let me know if any changes need to be made and I will happily make them, especially on the copy side of things as I did my best to encapsulate the essence of the module.
I am participating in Hacktoberfest and would love to have this PR count towards my total. No biggie if you can't but adding a "hacktoberfest-accepted" label to the PR would make it count for me!