Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor open graph metadata #4527

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

Technickel-Dev
Copy link
Contributor

Fixes #3151. By adding a og:title and og:description, the URL unfurl looks slicker! As a note, Discord seems to filter out < and > characters and the < and > characters screw with linting. The solution I found was to use Small Less-Than Sign and Small Greater-Than Sign unicode characters which convey the same meaning but don't screw with other systems.

Confirmed the changes worked and all tests passed. See the following examples from discord:
Before:
image

After:
image

Please let me know if any changes need to be made and I will happily make them, especially on the copy side of things as I did my best to encapsulate the essence of the module.

I am participating in Hacktoberfest and would love to have this PR count towards my total. No biggie if you can't but adding a "hacktoberfest-accepted" label to the PR would make it count for me!

Copy link
Collaborator

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Much improved.

packages/space-opera/editor/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elalish elalish merged commit da2b837 into google:master Oct 25, 2023
2 checks passed
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* Add href to AR button, improve accessibility

* Add Open Graph title and description for editor

* Broaden copy scope to include 3D, not just AR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL unfurl of modelviewer.dev/editor could be better
2 participants