-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-rotate doesn't rotate the model pivot if no model is loaded #471
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
698e483
to
12cc7af
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
12cc7af
to
10e4af2
Compare
@cdata This is ready for re-review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the contribution @pushmatrix 👍
Fixes #467
This fix checks to make sure that auto-rotation only starts once the poster is no longer visible and the model is interactable.
One thing is that this will not prevent the small stutter that happens when the poster transitions into 3D. That's because the rotation will start when the poster is dismissed, but the poster has a 0.3 second opacity transition. So during the transition you'll see the model rotation while the poster which is an image of the first frame will be fading away. It's not super noticeable, but it's also not perfectly smooth.
It may be more trouble than it's worth solving that case since we'd have to listen for when the opacity transition ends before triggering the rotation. And since the loading mixin and the staging mixin don't know about each other, that could be tricky.