Skip to content

Commit

Permalink
Protobuf file location refactoring part 1.
Browse files Browse the repository at this point in the history
This is a series of CLs to move *.proto files into protocol/ directory.
Following files will be moved in this CL.
- commands.proto
- candidates.proto

This is just a refactoring.  No user-visible behavior change should occur.

BUG=none
TEST=unittest
  • Loading branch information
hiroyuki-komatsu authored and yukawa committed May 31, 2015
1 parent 5afb412 commit dbe8005
Show file tree
Hide file tree
Showing 206 changed files with 377 additions and 284 deletions.
4 changes: 2 additions & 2 deletions src/android/genproto_java.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,8 @@
'type': 'none',
'variables': {
'proto_files': [
'../session/candidates.proto',
'../session/commands.proto',
'../protocol/candidates.proto',
'../protocol/commands.proto',
],
},
'actions': [
Expand Down
2 changes: 1 addition & 1 deletion src/android/jni/mozcjni.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include "base/system_util.h"
#include "base/version.h"
#include "engine/engine_factory.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "session/session_handler.h"
#include "session/session_usage_observer.h"
#include "usage_stats/usage_stats_uploader.h"
Expand Down
6 changes: 3 additions & 3 deletions src/chrome/nacl/nacl_extension.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,13 @@
'../../dictionary/dictionary_base.gyp:user_pos',
'../../net/net.gyp:http_client',
'../../net/net.gyp:json_util',
'../../session/session_base.gyp:key_parser',
'../../session/session_base.gyp:session_protocol',
'../../protocol/protocol.gyp:commands_proto',
'../../session/session.gyp:session',
'../../session/session.gyp:session_handler',
'../../session/session.gyp:session_usage_observer',
'../../usage_stats/usage_stats_base.gyp:usage_stats',
'../../session/session_base.gyp:key_parser',
'../../usage_stats/usage_stats.gyp:usage_stats_uploader',
'../../usage_stats/usage_stats_base.gyp:usage_stats',
],
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/chrome/nacl/nacl_session_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
#include "net/http_client_pepper.h"
#include "net/jsoncpp.h"
#include "net/json_util.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "session/session_handler.h"
#include "session/session_usage_observer.h"
#include "usage_stats/usage_stats.h"
Expand Down
2 changes: 1 addition & 1 deletion src/client/client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
#include "base/version.h"
#include "config/config.pb.h"
#include "ipc/ipc.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

#ifdef OS_MACOSX
#include "base/mac_process.h"
Expand Down
4 changes: 2 additions & 2 deletions src/client/client.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
'../base/base.gyp:base',
'../config/config.gyp:config_protocol',
'../ipc/ipc.gyp:ipc',
'../session/session_base.gyp:session_protocol',
'../protocol/protocol.gyp:commands_proto',
],
},
{
Expand All @@ -56,7 +56,7 @@
'dependencies': [
'../base/base.gyp:base',
'../config/config.gyp:config_protocol',
'../session/session_base.gyp:session_protocol',
'../protocol/protocol.gyp:commands_proto',
],
},
],
Expand Down
2 changes: 1 addition & 1 deletion src/client/client.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#include "base/port.h"
#include "base/scoped_ptr.h"
#include "client/client_interface.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "testing/base/public/gunit_prod.h"
// for FRIEND_TEST()

Expand Down
2 changes: 1 addition & 1 deletion src/client/client_interface.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

#include <string>
#include "base/port.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

namespace mozc {

Expand Down
2 changes: 1 addition & 1 deletion src/client/client_mock.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include <map>
#include <string>
#include "client/client_interface.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

namespace mozc {
namespace client {
Expand Down
2 changes: 1 addition & 1 deletion src/client/client_performance_test_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#include "base/util.h"
#include "client/client.h"
#include "config/config_handler.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "session/random_keyevents_generator.h"

DEFINE_string(server_path, "", "specify server path");
Expand Down
2 changes: 1 addition & 1 deletion src/client/client_quality_test_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include "base/util.h"
#include "client/client.h"
#include "evaluation/scorer.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

// Test data automatically generated by gen_client_quality_test_data.py
// TestCase test_cases[] is defined.
Expand Down
4 changes: 2 additions & 2 deletions src/client/client_scenario_test_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@
#include "base/system_util.h"
#include "base/util.h"
#include "client/client.h"
#include "renderer/renderer_command.pb.h"
#include "protocol/commands.pb.h"
#include "renderer/renderer_client.h"
#include "session/commands.pb.h"
#include "renderer/renderer_command.pb.h"
#include "session/key_parser.h"

DEFINE_bool(display_preedit, false, "display predit to tty");
Expand Down
2 changes: 1 addition & 1 deletion src/client/client_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
#include "base/util.h"
#include "base/version.h"
#include "ipc/ipc_mock.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "testing/base/public/gunit.h"

namespace mozc {
Expand Down
2 changes: 1 addition & 1 deletion src/client/client_test.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
],
'dependencies': [
'../base/base.gyp:base',
'../session/session_base.gyp:session_protocol',
'../protocol/protocol.gyp:commands_proto',
'client.gyp:client',
],
'actions': [
Expand Down
2 changes: 1 addition & 1 deletion src/composer/composer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#include "config/character_form_manager.h"
#include "config/config.pb.h"
#include "config/config_handler.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "session/key_event_util.h"

// Use flags instead of constant for performance evaluation.
Expand Down
5 changes: 2 additions & 3 deletions src/composer/composer.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,9 @@
'../config/config.gyp:config_handler',
'../config/config.gyp:config_protocol',
'../protobuf/protobuf.gyp:protobuf',
'../protocol/protocol.gyp:commands_proto',
'../session/session_base.gyp:key_event_util',
'../session/session_base.gyp:key_parser',
# This is needed. GYP is not smart enough about indirect dependencies.
'../session/session_base.gyp:session_protocol',
'../transliteration/transliteration.gyp:transliteration',
],
},
Expand All @@ -81,8 +80,8 @@
'dependencies': [
'../config/config.gyp:config_handler',
'../config/config.gyp:config_protocol',
'../protocol/protocol.gyp:commands_proto',
'../session/session_base.gyp:request_test_util',
'../session/session_base.gyp:session_protocol',
'../testing/testing.gyp:gtest_main',
'composer',
],
Expand Down
2 changes: 1 addition & 1 deletion src/composer/composer.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
#include "composer/internal/typing_corrector.h"
#include "composer/internal/transliterators.h"
#include "composer/type_corrected_query.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "transliteration/transliteration.h"
// for FRIEND_TEST()
#include "testing/base/public/gunit_prod.h"
Expand Down
2 changes: 1 addition & 1 deletion src/composer/composer_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include "base/scoped_ptr.h"
#include "composer/composition_interface.h"
#include "composer/table.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "transliteration/transliteration.h"

DEFINE_string(table, "system://romanji-hiragana.tsv",
Expand Down
2 changes: 1 addition & 1 deletion src/composer/composer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
#include "config/character_form_manager.h"
#include "config/config.pb.h"
#include "config/config_handler.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "session/key_parser.h"
#include "testing/base/public/gunit.h"

Expand Down
2 changes: 1 addition & 1 deletion src/composer/internal/typing_corrector_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include "composer/table.h"
#include "composer/type_corrected_query.h"
#include "composer/internal/typing_model.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "testing/base/public/gunit.h"

namespace mozc {
Expand Down
2 changes: 1 addition & 1 deletion src/composer/internal/typing_model.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "base/port.h"
#include "base/scoped_ptr.h"
#include "base/string_piece.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
// for FRIEND_TEST()
#include "testing/base/public/gunit_prod.h"

Expand Down
2 changes: 1 addition & 1 deletion src/composer/table.cc
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
#include "composer/internal/typing_model.h"
#include "config/config.pb.h"
#include "config/config_handler.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

namespace mozc {
namespace composer {
Expand Down
2 changes: 1 addition & 1 deletion src/composer/table_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
#include "composer/internal/composition_input.h"
#include "config/config.pb.h"
#include "config/config_handler.h"
#include "protocol/commands.pb.h"
#include "testing/base/public/gunit.h"
#include "session/commands.pb.h"

DECLARE_string(test_tmpdir);

Expand Down
2 changes: 1 addition & 1 deletion src/converter/conversion_request.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include "config/config_handler.h"
#include "converter/conversion_request.h"
#include "base/logging.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

namespace mozc {

Expand Down
2 changes: 1 addition & 1 deletion src/converter/converter.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
'../dictionary/dictionary_base.gyp:pos_matcher',
'../prediction/prediction.gyp:prediction',
'../prediction/prediction.gyp:prediction_protocol',
'../protocol/protocol.gyp:commands_proto',
'../rewriter/rewriter.gyp:rewriter',
'../session/session_base.gyp:session_protocol',
'../usage_stats/usage_stats_base.gyp:usage_stats',
'converter_base.gyp:conversion_request',
'converter_base.gyp:immutable_converter',
Expand Down
6 changes: 3 additions & 3 deletions src/converter/converter_base.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@
'../dictionary/dictionary.gyp:suffix_dictionary',
'../dictionary/dictionary_base.gyp:pos_matcher',
'../dictionary/dictionary_base.gyp:suppression_dictionary',
'../protocol/protocol.gyp:commands_proto',
'../rewriter/rewriter_base.gyp:gen_rewriter_files#host',
'../session/session_base.gyp:session_protocol',
'connector',
'immutable_converter_interface',
'segmenter',
Expand All @@ -140,7 +140,7 @@
],
'dependencies': [
'../base/base.gyp:base',
'../session/session_base.gyp:session_protocol',
'../protocol/protocol.gyp:commands_proto',
'segments',
'conversion_request',
],
Expand All @@ -164,7 +164,7 @@
],
'dependencies': [
'../base/base.gyp:base',
'../session/session_base.gyp:session_protocol',
'../protocol/protocol.gyp:commands_proto',
],
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/converter/converter_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
#include "engine/engine_factory.h"
#include "engine/engine_interface.h"
#include "engine/mock_data_engine_factory.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

DEFINE_int32(max_conversion_candidates_size, 200, "maximum candidates size");
DEFINE_string(user_profile_dir, "", "path to user profile directory");
Expand Down
2 changes: 1 addition & 1 deletion src/converter/converter_main.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
'../engine/engine.gyp:engine',
'../engine/engine.gyp:engine_factory',
'../engine/engine.gyp:mock_data_engine_factory',
'../session/session_base.gyp:session_protocol',
'../protocol/protocol.gyp:commands_proto',
'converter.gyp:converter',
'converter_base.gyp:pos_id_printer',
'converter_base.gyp:segments',
Expand Down
2 changes: 1 addition & 1 deletion src/converter/converter_regression_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include "converter/segments.h"
#include "engine/engine_factory.h"
#include "engine/engine_interface.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "testing/base/public/gunit.h"

#ifdef OS_ANDROID
Expand Down
2 changes: 1 addition & 1 deletion src/converter/converter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@
#include "prediction/predictor_interface.h"
#include "prediction/suggestion_filter.h"
#include "prediction/user_history_predictor.h"
#include "protocol/commands.pb.h"
#include "rewriter/rewriter.h"
#include "rewriter/rewriter_interface.h"
#include "session/commands.pb.h"
#include "testing/base/public/gunit.h"
#include "transliteration/transliteration.h"
#include "usage_stats/usage_stats.h"
Expand Down
4 changes: 2 additions & 2 deletions src/converter/converter_test.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@
'../engine/engine.gyp:engine_factory',
'../engine/engine.gyp:mock_data_engine_factory',
'../prediction/prediction_base.gyp:suggestion_filter',
'../protocol/protocol.gyp:commands_proto',
'../rewriter/rewriter.gyp:rewriter',
'../session/session_base.gyp:request_test_util',
'../session/session_base.gyp:session_protocol',
'../testing/testing.gyp:gtest_main',
'../transliteration/transliteration.gyp:transliteration',
'../usage_stats/usage_stats_test.gyp:usage_stats_testing_util',
Expand All @@ -86,8 +86,8 @@
'../config/config.gyp:config_handler',
'../engine/engine.gyp:engine',
'../engine/engine.gyp:engine_factory',
'../protocol/protocol.gyp:commands_proto',
'../session/session_base.gyp:request_test_util',
'../session/session_base.gyp:session_protocol',
'../testing/testing.gyp:gtest_main',
],
},
Expand Down
2 changes: 1 addition & 1 deletion src/converter/immutable_converter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
#include "dictionary/pos_matcher.h"
#include "dictionary/suppression_dictionary.h"
#include "prediction/suggestion_filter.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

using mozc::dictionary::DictionaryInterface;
using mozc::dictionary::POSMatcher;
Expand Down
2 changes: 1 addition & 1 deletion src/converter/immutable_converter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
#include "dictionary/system/value_dictionary.h"
#include "dictionary/user_dictionary_stub.h"
#include "prediction/suggestion_filter.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "testing/base/public/gunit.h"

DECLARE_string(test_tmpdir);
Expand Down
2 changes: 1 addition & 1 deletion src/converter/quality_regression_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#include "engine/chromeos_engine_factory.h"
#include "engine/engine_factory.h"
#include "engine/engine_interface.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"
#include "session/request_test_util.h"
#include "testing/base/public/gunit.h"

Expand Down
2 changes: 1 addition & 1 deletion src/converter/quality_regression_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#include "converter/conversion_request.h"
#include "converter/converter_interface.h"
#include "converter/segments.h"
#include "session/commands.pb.h"
#include "protocol/commands.pb.h"

namespace mozc {
namespace quality_regression {
Expand Down
2 changes: 1 addition & 1 deletion src/data/usage_stats/stats.def
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ Performed_Conversion_InputModeHalfAlphanumeric
Performed_Conversion_ReportBug
Performed_Conversion_DeleteSelectedCandidate

# The count of some SessionCommands defined in session/commands.proto
# The count of some SessionCommands defined in protocol/commands.proto
SendCommand_Revert
SendCommand_Submit
SendCommand_SelectCandidate
Expand Down
Loading

0 comments on commit dbe8005

Please sign in to comment.