Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ninja to build Mac binaries #247

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 0 comments
Closed

Use ninja to build Mac binaries #247

GoogleCodeExporter opened this issue Apr 22, 2015 · 0 comments
Labels
auto-migrated OpSys-OSX Priority-Medium Type-Enhancement

Comments

@GoogleCodeExporter
Copy link 

Now Ninja is used to build Mozc binaries for Windows, Linux, NaCl, and Android. 
 It would be great if we can unify the build environment by switching to Ninja 
from xcode build for OS X build.

Original issue reported on code.google.com by yukawa@google.com on 16 Aug 2014 at 6:50
yukawa added a commit that referenced this issue Sep 20, 2015
@yukawa
Clarify OSX build does not require Ninja yet.
74bb780 
This is a follow up CL for 276fa5c,
which mistakenly stated that OSX build requires Ninja.

Although we still plan to use Ninja for OSX build as mentioned
in #247, it is not yet done.  Until then, we don't have to ask people
to install Ninja when building Mozc for OSX.

BUG=#247
TEST=unittest
REF_BUG=
REF_CL=
@yukawa yukawa mentioned this issue Sep 20, 2015
Merged
hiroyuki-komatsu added a commit that referenced this issue Dec 31, 2015
@hiroyuki-komatsu @yukawa
Use mac_bundle_resources to specify resources.
14705d5 
Use mac_bundle_resources to specify resources instead of manual copies
instead of manual copies.  The result is not changed, but this is a
preferred way.

BUG=#247
TEST=compile
REF_BUG=22545802
REF_CL=100347864
hiroyuki-komatsu added a commit that referenced this issue Dec 31, 2015
@hiroyuki-komatsu @yukawa
Remove mac_dir and refactoring around breakpad.
0964d5e 
BUG=#247
TEST=compile
REF_BUG=22545802
REF_CL=100640682,106032939
hiroyuki-komatsu added a commit that referenced this issue Dec 31, 2015
@hiroyuki-komatsu @yukawa
Replace ${BUILT_PRODUCTS_DIR} with <(PRODUCT_DIR).
be24638 
GYP internally converts <(PRODUCT_DIR) with ${BUILT_PRODUCTS_DIR} on Mac
build.
https://gyp.gsrc.io/docs/InputFormatReference.md#Predefined-Variables

This CL should not change any results.  This is a refactoring.

BUG=#247
TEST=compile
REF_BUG=22545802
REF_CL=100648617
@yukawa yukawa closed this as completed in da34e1e Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated OpSys-OSX Priority-Medium Type-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter