Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible build failure due to missing dependency on 'commands_proto' from 'key_info_util' #295

Closed
yukawa opened this issue Aug 15, 2015 · 0 comments

Comments

@yukawa
Copy link
Collaborator

yukawa commented Aug 15, 2015

When commands.proto was moved from src/session/commands.proto to protocol/commands.proto by dbe8005, 'src/session/session_base.gyp' was not correctly updated to teach GYP that key_info_util GYP target depends on commands_proto GYP target. Although the lack of build dependency may or may not cause build failure depending on the build target and build order, the following command can always reproduce the build failure.

python build_mozc.py gyp
python build_mozc.py build -j1 -c Release session/session_base.gyp:key_info_util

Here is the error message you would see.

ninja: Entering directory `out_linux/Release'
[78/80] CXX obj/session/key_info_util.key_info_util.o
FAILED: /usr/bin/clang++ -MMD -MF obj/session/key_info_util.key_info_util.o.d -DOS_LINUX -DMOZC_BUILD -DCHANNEL_DEV -DENABLE_GTK_RENDERER -DMOZC_ENABLE_UNITTEST -DNDEBUG -DQT_NO_DEBUG -DNO_LOGGING -DIGNORE_HELP_FLAG -DIGNORE_INVALID_FLAG -I/home/mozc_builder/work/mozc/src -Igen -Igen/proto_out -I../../third_party/protobuf/src -Wall -Wno-char-subscripts -Wno-sign-compare -Wno-deprecated-declarations -Wwrite-strings -fPIC -fno-exceptions -fmessage-length=0 -fno-strict-aliasing -funsigned-char -include base/namespace.h -pipe -pthread -fno-omit-frame-pointer -fstack-protector --param=ssp-buffer-size=4 -Wtype-limits -O2 -Wno-deprecated -Wno-covered-switch-default -Wno-unnamed-type-template-args -Wno-c++11-narrowing -std=gnu++0x -std=gnu++0x  -c ../../session/key_info_util.cc -o obj/session/key_info_util.key_info_util.o
../../session/key_info_util.cc:43:10: fatal error: 'protocol/commands.pb.h' file not found
#include "protocol/commands.pb.h"
         ^
1 error generated.
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "build_mozc.py", line 1454, in <module>
    main()
  File "build_mozc.py", line 1450, in main
    procedure[1](cmd_opts, cmd_args, original_directory_name)
  File "build_mozc.py", line 1070, in BuildMain
    BuildOnLinux(options, targets, original_directory_name)
  File "build_mozc.py", line 1026, in BuildOnLinux
    RunOrDie([make_command] + build_args + target_names)
  File "/home/mozc_builder/work/mozc/src/build_tools/util.py", line 99, in RunOrDie
    '==========']))
build_tools.util.RunOrDieError: 
==========
 ERROR: ninja -j 1 -C out_linux/Release key_info_util
==========
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant