Support 'icon_prop_key' entry in ibus-mozc #344
Assignees
Labels
Comments
yukawa
added a commit
that referenced
this issue
Jan 10, 2016
Fixes #344. Showing a status icon instead of the IME's product icon is a new feature introduced by ibus/ibus@23c45b9 and has been available since IBus 1.5.11. Hence this CL adds 'icon_prop_key' to mozc.xml when the IBus version is 1.5.11 or later. Although supporting new IBus feature is not our goal any more, supporting his feature before we delete ibus-mozc in #287 may help some people. One thing you should keep in mind is that the version of IBus is checked at build time, not run-time. This means that if you upgrade IBus from 1.5.10 or prior to 1.5.11 or later then you have to rebuild ibus-mozc so that mozc.xml can be updated. BUG=#344 TEST=manually done on Fedora 23 KDE Plasma Desktop. REF_BUG= REF_CL=111381977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
ibus-mozc 2.17.2287.103 running on Fedora 23 KDE Plasma Desktop.
Steps to reproduce:
Show icon on system trayis enabled on theibus-settingdialog.Expected behavior:
Status icon such as
あandAis displayed on the KDE5 system tray.Hiragana Mode
Katakana Mode
Direct Mode
Actual behavior:
Mozc's product icon
is displayed on the KDE5 system tray.
Additional Information:
Showing a status icon instead of the IME's product icon is a new feature introduced by ibus/ibus@23c45b9 and has been available since IBus 1.5.11.
Basically all we need to do is just to add
<icon_prop_key>entry inmozc.xmlwhen IBus is 1.5.11 or greater. Although supporting new IBus feature is not our goal any more, doing this before we delete ibus-mozc in #287 may help some people.The text was updated successfully, but these errors were encountered: