Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add monitor on table chain rule set setelem and obj events #250

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat: add monitor on table chain rule set setelem and obj events #250

merged 4 commits into from
Dec 13, 2023

Conversation

singchia
Copy link
Contributor

@singchia singchia commented Dec 7, 2023

  • add monitor feature
  • optimize multiple header types assertion(which needed by monitor)

@singchia singchia mentioned this pull request Dec 7, 2023
Closed
stapelberg
stapelberg requested changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@stapelberg stapelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Did a first review, but I probably have more comments once these are out of the way :)

go.sum Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
monitor_test.go Outdated Show resolved Hide resolved
stapelberg
stapelberg requested changes Dec 9, 2023
View reviewed changes
monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
stapelberg
stapelberg reviewed Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@stapelberg stapelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! When you resolve the remaining two comments, I think this is ready to be merged :)

monitor.go Outdated Show resolved Hide resolved
monitor.go Outdated Show resolved Hide resolved
@stapelberg stapelberg merged commit 5555df3 into google:main Dec 13, 2023
2 checks passed
@singchia singchia deleted the feat/monitor branch December 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stapelberg stapelberg stapelberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singchia @stapelberg