Objects implementation refactor #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
reviewed
Apr 18, 2024
turekt
force-pushed
the
obj-impl-refactor
branch
from
54b203b
to
b77f1a9
Compare
turekt
force-pushed
the
obj-impl-refactor
branch
3 times, most recently
from
bf1fedd
to
c6bcfd9
Compare
turekt
force-pushed
the
obj-impl-refactor
branch
from
c6bcfd9
to
533a934
Compare
stapelberg
reviewed
Jul 21, 2024
turekt
force-pushed
the
obj-impl-refactor
branch
from
533a934
to
a8e056d
Compare
|
Alright, PR #265 is now merged, so you can rebase this one. |
turekt
force-pushed
the
obj-impl-refactor
branch
from
a8e056d
to
b5406ff
Compare
stapelberg
requested changes
Jul 25, 2024
turekt
force-pushed
the
obj-impl-refactor
branch
2 times, most recently
from
717c691
to
eab2afa
Compare
Refactored obj.go to a more generic approach Added object support for already implemented expressions Added test for limit object Fixes google#253
turekt
force-pushed
the
obj-impl-refactor
branch
from
eab2afa
to
955947b
Compare
stapelberg
approved these changes
Jul 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as per our discussion in #253, I have implemented a change for a more generic implementation of nftables objects. In addition to the refactor I have added a test to demonstrate that already implemented expressions are now supported as objects and made a few lint changes. Note that some of the expressions are currently not implemented in the lib (i.e. synproxy, ct_helper, ct_expect, ...). These can now be easily added to the
exprpackage to offer support. I'll see to adding them after we agree on this refactor change.Let me know what you think.