Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test refactoring #87

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test refactoring #87

wants to merge 4 commits into from

Conversation

alexispires
Copy link
Contributor

@alexispires alexispires commented Dec 25, 2019 •
edited
Loading

  • Common TestDial function

@stapelberg
Copy link
Collaborator

Thanks, looks like a good first start. Let me know once this is ready for review

@alexispires
Copy link
Contributor Author

alexispires commented Jan 12, 2020 •
edited
Loading

@stapelberg
What do you think if:

  • I put all unit tests in specific files (nat_test.go, verdict_test.go..)
  • I put integration test in a single file nftables_integration_test.go
  • I put helper functions in a single file helpers_test.go

@stapelberg
Copy link
Collaborator

Sounds good to me!

@alexispires alexispires marked this pull request as ready for review January 13, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexispires @stapelberg @apiresatos