Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #25

Merged
merged 1 commit into from
Apr 17, 2018
Merged

chore: cleanup #25

merged 1 commit into from
Apr 17, 2018

Conversation

jinwoo
Copy link
Member

@jinwoo jinwoo commented Apr 17, 2018

  • Record a path as a static file only when it starts with the static
    directory prefix
  • Don't store REQ_PATH onto the stream. Just retrieve it from the raw
    request object

* Record a path as a static file only when it starts with the static
  directory prefix
* Don't store REQ_PATH onto the stream. Just retrieve it from the raw
  request object
@jinwoo jinwoo requested review from ofrobots and a team April 17, 2018 19:57
@jinwoo
Copy link
Member Author

jinwoo commented Apr 17, 2018

/cc @mcollina

This is a cleanup while investigating #23.

@codecov-io
Copy link

Codecov Report

Merging #25 into master will increase coverage by 2.7%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #25     +/-   ##
=========================================
+ Coverage   94.59%   97.29%   +2.7%     
=========================================
  Files           1        1             
  Lines          37       37             
  Branches        7        8      +1     
=========================================
+ Hits           35       36      +1     
+ Misses          2        1      -1
Impacted Files Coverage Δ
ts/src/index.ts 97.29% <90.9%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36cf5fb...5cab729. Read the comment docs.

@jinwoo jinwoo merged commit 8cde236 into google:master Apr 17, 2018
@jinwoo jinwoo deleted the fix branch April 17, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants