Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sample app #5

Merged
merged 2 commits into from
Jan 20, 2018
Merged

chore: add sample app #5

merged 2 commits into from
Jan 20, 2018

Conversation

jinwoo
Copy link
Member

@jinwoo jinwoo commented Jan 18, 2018

It is a static file server that uses fastify and the
fastify-auto-push plugin.

@jinwoo jinwoo requested review from ofrobots and a team January 18, 2018 21:46
@codecov-io
Copy link

codecov-io commented Jan 18, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   76.31%   76.31%           
=======================================
  Files           1        1           
  Lines          38       38           
  Branches        9        9           
=======================================
  Hits           29       29           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ea9d9...4c4be76. Read the comment docs.

It is a static file server that uses `fastify` and the
`fastify-auto-push` plugin.
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, the sample assets are from third party sources, so they should be housed in a third_party directory.

@jinwoo
Copy link
Member Author

jinwoo commented Jan 19, 2018

Moved the static files to the third_party directory. Also added LICENSE and README there. PTAL.

@jinwoo jinwoo merged commit 93b11c8 into google:master Jan 20, 2018
@jinwoo jinwoo deleted the sample branch January 20, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants