Drop GAE user ID from RegistryPoc table #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianglai
force-pushed
the
drop-gae-user-id
branch
from
8ca1c8f to
31e5124
Compare
jianglai
force-pushed
the
drop-gae-user-id
branch
from
31e5124 to
0c3e8d7
Compare
jianglai
added
kokoro:force-run
|
PTAL. Presubmits now pass with the latest deployment that removed Java code dependencies on the columns to be removed. Will not merge until after at least a few weeks of running with the new email address based console login flow. |
gbrodman
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jianglai)
jianglai
force-pushed
the
drop-gae-user-id
branch
from
0c3e8d7 to
5217ad9
Compare
jianglai
force-pushed
the
drop-gae-user-id
branch
from
5217ad9 to
219acc6
Compare
It has been replaced by the login email address.
jianglai
force-pushed
the
drop-gae-user-id
branch
from
219acc6 to
7f14043
Compare
jianglai
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been replaced by the login email address.
This change is