Add default tokens to TLD using nomulus tool

[sarahcaseybot]

This change is 

[gbrodman]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @sarahcaseybot)

---

core/src/main/java/google/registry/tools/CreateOrUpdateTldCommand.java line 243 at r1 (raw file):

          "A comma-separated list of default allocation tokens to be applied to the TLD. The"
              + " ordering of this list will determine which token is used in the case where"
              + " multiple tokens are valid for a registration.")

nit, maybe include something about an empty string setting the list to be empty?

---

core/src/main/java/google/registry/tools/UpdateOrDeleteAllocationTokensCommand.java line 60 at r1 (raw file):

          tokens.stream()
              .map(token -> VKey.create(AllocationToken.class, token))
              .collect(Collectors.toList());

better to use the toImmutableList() collector instead both here and the couple spots below

---

core/src/test/java/google/registry/tools/UpdateTldCommandTest.java line 241 at r1 (raw file):

    assertThat(Registry.get("xn--q9jyb4c").getDefaultPromoTokens()).isEmpty();
  }

can we have a test or two covering re-ordering of default tokens and/or removing some without removing all?

[sarahcaseybot]

Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @gbrodman)

---

core/src/main/java/google/registry/tools/UpdateOrDeleteAllocationTokensCommand.java line 60 at r1 (raw file):

Previously, gbrodman wrote…

better to use the toImmutableList() collector instead both here and the couple spots below

Done.

---

core/src/test/java/google/registry/tools/UpdateTldCommandTest.java line 241 at r1 (raw file):

Previously, gbrodman wrote…

can we have a test or two covering re-ordering of default tokens and/or removing some without removing all?

You can only replace the entire list, not just add/remove one token. Added another test

[gbrodman]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sarahcaseybot)

---

core/src/test/java/google/registry/tools/UpdateTldCommandTest.java line 241 at r1 (raw file):

Previously, sarahcaseybot wrote…

You can only replace the entire list, not just add/remove one token. Added another test

derp of course