Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surfacing browser errors #142

Merged
merged 21 commits into from
Sep 3, 2022
Merged

Surfacing browser errors #142

merged 21 commits into from
Sep 3, 2022

Conversation

ulisesL
Copy link
Collaborator

@ulisesL ulisesL commented Sep 2, 2022

Hi Andy,

Changes in this commit will allow for debugging errors when opening the browser in the 3LO loop back flow.

Thanks,
Ulises

ulisesL and others added 21 commits July 7, 2022 15:12
@ulisesL
Enable 3LO loopback tests. Fix cache's key creation.
9dd99d9
@ulisesL
Refactor 3LO loopback logic as callback functions.
00aa13a
@ulisesL
Set loopback server endpoints in constants.
d876401
@ulisesL
Force new entry in cache for 3LO loopback test cases.
e44d4b9
@ulisesL
Improve postCommandLogic and preCommandLogic comments.
cfa2c13
@ulisesL
Change post/preComndLogic to post/preCmdLogic.
bc835b6
@ulisesL
Add runTestScenariosWithAdvancedLogic fucntion to handle pre/post exe…
7583f68 
…c command logic.
@ulisesL
Update TODO in Test3LOLoopbackFlow and improve comments.
858d42d
@ulisesL
Update preLogic in Test3LOLoopbackFlow to save CPU cycles.
2bc7382
@ulisesL
Add description for getCredentialsFileName helper function.
38d228f
@ulisesL
Add client_email's value into fake-client-secret files.
3cf407b
@ulisesL
Implement removeRedirectUriPort in cli_test.go.
68bc2f1
@ulisesL
Create temp credentials file, instead of modifying original.
77fdef2
@ulisesL
Simplify loopback ogig in preLogic. Add safetynet so that loopback lo…
330d7ef 
…gic does not loop forever in preLogic.
@ulisesL
Fix typos.
8224c82
@ulisesL
Move redirect uri selection logic. Improve loopback logic.
0247c0f
@ulisesL
Make runTestScenariosWithInputAndProcessedOutput call runTestScenario…
360d2ad 
…sWithAdvancedLogic.
@ulisesL
Improve post logic comments.
6a087f0
@ulisesL
Merge branch 'google:master' into master
7c2f124
@ulisesL
Surface browser errors.
63f63be
@ulisesL
Refactor Print statement for browser errors.
0b06ea5
@ulisesL ulisesL requested a review from andyrzhao September 2, 2022 17:17
andyrzhao
andyrzhao approved these changes Sep 3, 2022
View reviewed changes
Copy link
Collaborator

@andyrzhao andyrzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyrzhao andyrzhao merged commit 1742d0d into google:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyrzhao andyrzhao andyrzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulisesL @andyrzhao