Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OboeTester Data Paths handle mix of USB #2083

Merged
merged 2 commits into from
Aug 7, 2024
Merged

OboeTester Data Paths handle mix of USB #2083

merged 2 commits into from
Aug 7, 2024

Conversation

philburk
Copy link
Collaborator

@philburk philburk commented Aug 5, 2024

Handle any combination of USB Headset or Device.

Handle any combination of USB Headset or Device.
@philburk philburk requested a review from robertwu1 August 6, 2024 22:38
Copy link
Collaborator

@robertwu1 robertwu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See findCompatibleInputDevice.

If there is a usb device AND a USB headset exposed, should we prefer the usb headset input for the usb headset output and the usb device output for the usb headset input?

Are there any USB device that we know of that exposes both a USB device and a USB headset endpoint?

@philburk
Copy link
Collaborator Author

philburk commented Aug 7, 2024

Interesting idea. I changed it to supported preferred order.

Are there any USB device that we know of that exposes both a USB device and a USB headset endpoint?

The Rode NT USB Mini is the only one I know of.
This code was written to fix:
b/356818652 | P2 | Oboe tester failed to execute data paths tests with Rode NT USB Mini

@philburk philburk merged commit 9fa656d into main Aug 7, 2024
3 checks passed
@philburk philburk deleted the usb_compat branch August 7, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants