Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix presubmit warnings #444

Merged
merged 2 commits into from
Jul 7, 2024
Merged

report: fix presubmit warnings #444

merged 2 commits into from
Jul 7, 2024

Conversation

DavidKorczynski
Copy link
Collaborator

There's a handful of warnings when changing things in report/common.py and this fixes them all.

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun skip

@DavidKorczynski
report: fix presubmit warnings
5ad6eb1 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski
report: fix remainder warnings
35ccb63 
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski requested a review from DonggeLiu July 6, 2024 17:51
DonggeLiu
DonggeLiu approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@DonggeLiu DonggeLiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this in a separate PR!

@DonggeLiu DonggeLiu merged commit 6e93ece into main Jul 7, 2024
7 checks passed
@DonggeLiu DonggeLiu deleted the fix-webapp-warnings branch July 7, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidKorczynski @DonggeLiu