Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM: Fix exception description in prompt #489

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

arthurscchan
Copy link
Collaborator

@arthurscchan arthurscchan commented Jul 15, 2024

This PR fixes the exceptions information shown in the JVM prompt to allow LLM to read correct exception information that is needed to catch in the generated harnesses. This PR also improves the JVM prompt by adding exceptions details of object constructors / methods that create the needed object for method invocation that is originally suggested in #488. Because of its similarity, changes suggested in #488 is also added in the PR.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@arthurscchan arthurscchan marked this pull request as ready for review July 15, 2024 21:05
Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix formatting

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@arthurscchan arthurscchan marked this pull request as draft July 16, 2024 10:32
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@arthurscchan arthurscchan marked this pull request as ready for review July 16, 2024 10:52
@DavidKorczynski
Copy link
Collaborator

/gcbrun skip

@DavidKorczynski DavidKorczynski merged commit 9a5b247 into google:main Jul 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants